Lycen's SW Application
LycenTheDead last edited by
Rank: Script Writer
Reason & Motivation:
I'm very interested in continuing to improve along with this community.
I enjoy the community, and the devs/admins have all been extremely helpful - both recently, and when I first began.
I am a software developer. I have a degree in CS, and I've been writing scripts for about 2 years, off and on, for various clients.
I primarily work in python, but have experience in Java. It's been coming back to me gradually.
I have put some serious effort into taking in suggestions and improving my latest script. I am willing to receive constructive criticism.
I believe both of these scripts are serious improvements compared to my earlier scripts.
Thanks for your consideration,
Thank you for submitting an application to join the script writer team. Unfortunately, I apologize as your application has been denied. Here at RSPeer we like to maintain a high standard of code that we feel has not been met by your application.
You are encouraged by our staff team to apply again for openings for which you qualify in the future. We appreciate that you took the time to apply.
These threads may prove helpful to you
I know you worked hard to improve and I'm glad you are doing so, I just feel like you still are not that the level that we would like to see our SW's at. If you keep improving, you'll eventually get there.
A couple areas that staff thought were a little rough and more towards the mentality of an intermediate scripter:
I'm wasn't able to make sense on why there is no many nested interacts here.
as well. This sends a request to your server every loop, which is a large waste in resources that both hammers your server and slows down your loop by having to wait for a reply from your server. It would become an issue when hundreds of users are running your script and your server slows.
Final point: Alot of this stuff should be abstracted away behind a class and only exposed what needs to be exposed, that is one of the main factors in proper OOP.
Feel free to ask in the development channel in our discord for tips on how to improve your code.
Thank you for submitting an application to join the script writer team. Unfortunately, I apologize as your application has been denied. Here at RSPeer we like to maintain a high standard of code that we feel has not been met by your application, feel free to ask for help in the discord to have concepts that you may have difficulty understanding explained to you.
You are encouraged by our staff team to apply again for openings for which you qualify in the future. We appreciate that you took the time to apply. These threads may prove helpful to you https://forums.rspeer.org/topic/52/tips-for-writing-solid-scripting-logic/ https://forums.rspeer.org/topic/50/requirements-uploading-scripts-script-writer-the-script-developer-rank/
Upon looking through your code one thing that jumps out to me is the nesting. I believe that you should work on abstracting your code more to make it not only look cleaner, but make it a lot nicer for you to maintain. A good place to start would be the method at line 160 in the Main class of LMasterFarmers. Aside from this, there are a few other things you are lacking on such as Java code conventions, static sleeping, some poor use of the API (Your use of Inventory.contains and then getFirst requires 2 lookups - instead of this, you should use getFirst and then null check instead of using contains). Also, your PHP post request is being sent every loop, this is probably something you'd want to avoid, even more so if it's intended to be used as a public script.
Kind Regards, Spencer
Edit: Lol Mad beat me to it